Pre-downloads and caches the Gradle distribution#28247
Pre-downloads and caches the Gradle distribution#28247yuslepukhin wants to merge 3 commits intomainfrom
Conversation
before cmake --build runs. Makes subsequent runs faster due to the built-in Gradle cache. Eliminates the dependency on GitHub's release CDN being reachable at build time
There was a problem hiding this comment.
Pull request overview
Updates the Windows CUDA GitHub Actions workflow to ensure Gradle is installed and cached consistently before Java-related build/test steps run, improving reliability of Gradle-dependent tasks on self-hosted runners.
Changes:
- Add a
Setup Gradlestep (viagradle/actions/setup-gradle@v4) to the Windows CUDA build job. - Add the same
Setup Gradlestep to the Windows CUDA test job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This adds a dependency on an externally build action, but I don't see how it improves anything. What benefits does this bring vs just using the customary gradle bootstrap? |
sanaa-hamel-microsoft
left a comment
sanaa-hamel-microsoft
left a comment
There was a problem hiding this comment.
Requesting feedback on concrete benefits from adding external dependency.
|
I am not an expert in it. |
This pull request updates the GitHub Actions workflow for Windows CUDA builds by adding a dedicated step to set up Gradle using the official Gradle action. This ensures that Gradle version 8.7 is reliably installed and configured in the workflow before subsequent steps execute.
Workflow improvements:
Setup Gradlestep usinggradle/actions/setup-gradle@v4withgradle-version: '8.7'to the Windows CUDA workflow, ensuring consistent Gradle setup for build and test jobs. [1] [2]